chore: release 5.22

implemented #970

descriptions/ab+/en_us.lua

@@ -757,7 +757,7 @@ EID.descriptions[languageCode].trinkets={
 	{"17", "Black Lipstick", "{{BlackHeart}} +10% chance for random Soul Hearts to spawn as Black Hearts"}, -- Black Lipstick
 	{"18", "Bible Tract", "{{EternalHeart}} +3% chance for Eternal Hearts"}, -- Bible Tract
 	{"19", "Paper Clip", "{{GoldenChest}} Gold chests can be opened for free"}, -- Paper Clip
-	{"20", "Monkey Paw", "{{BlackHeart}} Spawns 1 Black Heart when Isaac's health is reduced to half a heart#{{Warning}} Disappears after spawning 3 Black Hearts"}, -- Monkey Paw
+	{"20", "Monkey Paw", "{{BlackHeart}} Spawns 1 Black Heart when Isaac's health is damaged down to half a heart#{{Warning}} Disappears after spawning 3 Black Hearts"}, -- Monkey Paw
 	{"21", "Mysterious Paper", "Randomly grants the effect of: #{{Collectible327}} The Polaroid#{{Collectible328}} The Negative#{{Trinket48}} A Missing Page#{{Trinket23}} Missing Poster"}, -- Mysterious Paper
 	{"22", "Daemon's Tail", "{{Heart}} Decreases spawn rate of hearts to 20%#{{BlackHeart}} All Heart pickups turn into Black Hearts#{{Key}} Increases the drop chance of keys"}, -- Daemon's Tail
 	{"23", "Missing Poster", "{{Player10}} Respawn as The Lost on death"}, -- Missing Poster
@@ -770,7 +770,7 @@ EID.descriptions[languageCode].trinkets={
 	{"30", "Pinky Eye", "{{Poison}} 10% chance to shoot poison tears#{{Luck}} 100% chance at 18 luck"}, -- Pinky Eye
 	{"31", "Push Pin", "10% chance to shoot piercing + spectral tears#{{Luck}} 100% chance at 18 luck"}, -- Push Pin
 	{"32", "Liberty Cap", "25% chance for a random mushroom effect per room#Can reveal special rooms on the minimap"}, -- Liberty Cap
-	{"33", "Umbilical Cord", "{{Timer}} Spawns {{Collectible100}} Little Steven for the room when Isaac's health is reduced to half a heart"}, -- Umbilical Cord
+	{"33", "Umbilical Cord", "{{Timer}} Spawns {{Collectible100}} Little Steven for the room when Isaac's health is damaged down to half a heart"}, -- Umbilical Cord
 	{"34", "Child's Heart", "{{UnknownHeart}} 10% chance for the room clear reward to be a random heart#{{Heart}} 33% chance for a bonus heart from chests, tinted rocks, and destroyed machines"}, -- Child's Heart
 	{"35", "Curved Horn", "↑ {{Damage}} +2 Damage"}, -- Curved Horn
 	{"36", "Rusted Key", "{{Key}} 10% chance for the room clear reward to be a key#{{Key}} 33% chance for a bonus key from chests, tinted rocks, and destroyed machines"}, -- Rusted Key

descriptions/ab+/ko_kr.lua

@@ -36,7 +36,6 @@ EID.descriptions[languageCode].alternativeLanguageCodes = {"koreana", "kr", "ko"
 	korean_gulim(굴림) - A font that was used from former EID Korean. Recommended LineHeight : 13
 
 	korean_yoonwebdotum10, korean_galmoori9, korean_galmoori11 is added for community request.
-	eid_korean_hcrdotum_0.png is untouched due to game crashes for changing file names.
  ]]
 EID.descriptions[languageCode].fonts = {
 	{name="korean_yoonwebdotum10_shadow", lineHeight=13, textboxWidth = 175},

descriptions/rep/ru.lua

@@ -573,7 +573,7 @@ EID.descriptions[languageCode].bookOfVirtuesWisps = {
 	[287] = "Эффект Треснувшего шара при разрушении", -- Book of Secrets
 	[288] = "Вместо пауков создаются огоньки#Создаётся синий паук при разрушении", -- Box of Spiders
 	[289] = "Огонёк на одну комнату#Стреляет красным огнём", -- Red Candle
-	[290] = "Вместо эффекта создаёт огонёк за каждое сердце#Шанс создать половинку сердца при зарзушении", -- The Jar
+	[290] = "Вместо эффекта создаёт огонёк за каждое сердце#Шанс создать половинку сердца при зарзушение", -- The Jar
 	[291] = "Spawns an extra wisp per pooped enemy", -- Flush!
 	[292] = "+10% к шансу сделок за каждый огонёк Сатанинской Библии", -- Satanic Bible
 	[293] = "Выстреливает лазер в 4 направления при разрушении", -- Head of Krampus
@@ -818,6 +818,18 @@ EID.descriptions[languageCode].goldenTrinketEffects = {
 	[159] = { "Заменяет все сундуки (кроме Старых/Мега) золотыми сундуками#Золотые сундуки могут содержать больше карт, пилюль или брелоков" },
 }
 
+--[[
+Localizations may choose to overwrite specific data from EID.GoldenTrinketData in this table. For advanced users only.
+Example: If French uses "Double" instead of "2x" for Purple Heart, they can do:
+EID.descriptions[languageCode].goldenTrinketData = {
+	[5] = {findReplace = true, mult = 2},
+}
+and then place
+	[5] = { "Double", "Quadruple" },
+in their goldenTrinketEffects
+]]
+EID.descriptions[languageCode].goldenTrinketData = { }
+
 ---------- Cards ----------
 
 local repCards={

features/eid_bagofcrafting.lua

@@ -233,6 +233,18 @@ function EID:calculateBagOfCrafting(componentsTable)
 	table.sort(components)
 	local componentsAsString = table.concat(components, ",")
 
+	-- calculate the game's actual output, including any modifications to recipes.xml
+	if REPENTOGON and EntityPlayer.CalculateBagOfCraftingOutput then
+		local cacheResult = calculatedRecipes[componentsAsString]
+		if cacheResult ~= nil then
+			return cacheResult
+		end
+
+		local collectible, _ = EntityPlayer.CalculateBagOfCraftingOutput(components)
+		calculatedRecipes[componentsAsString] = collectible
+		return collectible
+	end
+
 	-- Check the fixed recipes
 	local cacheResult = CraftingFixedRecipes[componentsAsString]
 	if cacheResult ~= nil then

features/eid_data.lua

@@ -1176,10 +1176,60 @@ EID.BlackFeatherTrinkets = { [17] = true, [22] = true }
 
 -- Luck formulas
 EID.LuckFormulas = {}
-EID.LuckFormulas["5.100.219"] = function(luck) return math.min(100 / (10 - math.floor(luck*0.3)), 50) end -- Old Bandage: Base 10%, 50% at 26.67 Luck
+EID.LuckFormulas["5.100.55"] = function(luck) return (100 / math.max(1, (2 - math.floor(luck*0.5)))) end -- Mom's Eye: Base 50%, 100% at 2 Luck
+EID.LuckFormulas["5.100.87"] = function(luck) return (100 / math.max(1, (8 - math.floor(luck)))) end -- Loki's Horns: Base 12.5%, 100% at 7 Luck
+EID.LuckFormulas["5.100.89"] = function(luck) return (100 / math.max(1, (4 - math.floor(luck/5)))) end -- Spider Bite: Base 25%, 100% at 15 Luck
+EID.LuckFormulas["5.100.103"] = function(luck) return (100 / math.max(1, (4 - math.floor(luck/4)))) end -- The Common Cold: Base 25%, 100% at 12 Luck
+EID.LuckFormulas["5.100.110"] = function(luck) return (100 / math.max(2, (5 - math.floor(luck*0.15)))) end -- Mom's Contacts: Base 20%, 50% at 20 Luck
+EID.LuckFormulas["5.100.150"] = function(luck) return (100 / math.max(1, (10 - math.floor(luck)))) end -- Tough Love: Base 10%, 100% at 9 Luck
+EID.LuckFormulas["5.100.162"] = function(luck) return (100 / math.max(1, (5 - math.floor(luck*0.15)))) end -- Celtic Cross: Base 20%, 100% at 26.67 Luck
+EID.LuckFormulas["5.100.200"] = function(luck) return (100 / math.max(1, (10 - math.floor(luck/3)))) end -- Mom's Eyeshadow: Base 10%, 100% at 27 Luck
+EID.LuckFormulas["5.100.201"] = function(luck) return (100 / math.max(1, (10 - math.floor(luck/3)))) end -- Iron Bar: Base 10%, 100% at 27 Luck
+EID.LuckFormulas["5.100.217"] = function(luck) return (100 / math.max(1, (20 - math.floor(luck*2)))) end -- Mom's Wig: Base 5%, 100% at 9.5 Luck
+EID.LuckFormulas["5.100.219"] = function(luck) return (100 / math.max(2, (10 - math.floor(luck*0.3)))) end -- Old Bandage: Base 10%, 50% at 26.67 Luck
+EID.LuckFormulas["5.100.225"] = function(luck) return (100 / math.max(2, (10 - math.floor(luck*0.4)))) end -- Gimpy: Base 10%, 50% at 20 Luck
+EID.LuckFormulas["5.100.228"] = function(luck) return (1500 / math.max(15, (100 - math.floor(luck)))) end -- Mom's Perfume: Base 15%, 100% at 85 Luck
+EID.LuckFormulas["5.100.230"] = function(luck) return (1500 / math.max(15, (100 - math.floor(luck)))) end -- Abaddon: Base 15%, 100% at 85 Luck
+EID.LuckFormulas["5.100.231"] = function(luck) return (100 / math.max(1, (10 - math.floor(luck*0.5)))) end -- Ball of Tar: Base 10%, 100% at 18 Luck
+EID.LuckFormulas["5.100.257"] = function(luck) return (100 / math.max(1, (10 - math.floor(luck*0.7)))) end -- Fire Mind: Base 10%, 100% at 12.86 Luck
+EID.LuckFormulas["5.100.259"] = function(luck) return (100 / math.max(1, (3 - math.floor(luck*0.1)))) end -- Dark Matter: Base 33.3%, 100% at 20 Luck
+EID.LuckFormulas["5.100.303"] = function(luck) return (100 / math.max(1, (4 - math.floor(luck*0.3)))) end -- Virgo: Base 25%, 100% at 10 Luck
+EID.LuckFormulas["5.100.374"] = function(luck) return (100 / math.max(2, (10 - math.floor(luck*0.9)))) end -- Holy Light: Base 10%, 50% at 8.89 Luck
+EID.LuckFormulas["5.100.410"] = function(luck) return (100 / math.max(10, (30 - math.floor(luck)))) end -- Evil Eye: Base 3.33%, 10% at 20 Luck
+EID.LuckFormulas["5.100.443"] = function(luck) return (100 / math.max(1, (15 - math.floor(luck)))) end -- Apple!: Base 6.66%, 100% at 14 Luck
+EID.LuckFormulas["5.100.461"] = function(luck) return (100 / math.max(2, (7 - math.floor(luck)))) end -- Parasitoid: Base 14.3%, 50% at 5 Luck
+EID.LuckFormulas["5.100.496"] = function(luck) return (100 / math.max(1, (30 - math.floor(luck*2)))) end -- Euthanasia: Base 3.33%, 100% at 14.5 Luck
+EID.LuckFormulas["5.100.503"] = function(luck) return (100 / math.max(5, (20 - math.floor(luck)))) end -- Little Horn: Base 5%, 20% at 15 Luck
+EID.LuckFormulas["5.350.8"] = function(luck) return (100 / math.max(1, (20 - math.floor(luck*0.5)))) end -- Cartridge: Base 5%, 100% at 38 Luck
+EID.LuckFormulas["5.350.30"] = function(luck) return (100 / math.max(1, (10 - math.floor(luck*0.5)))) end -- Pinky Eye: Base 10%, 100% at 18 Luck
+EID.LuckFormulas["5.350.31"] = function(luck) return (100 / math.max(1, (10 - math.floor(luck*0.5)))) end -- Push Pin: Base 10%, 100% at 18 Luck
+EID.LuckFormulas["5.350.46"] = function(luck) return (100 / math.max(1, (10 - math.floor(luck*0.5)))) end -- Isaac's Fork: Base 10%, 100% at 18 Luck
+EID.LuckFormulas["5.350.48"] = function(luck) return (100 / math.max(2, (20 - math.floor(luck*0.3)))) end -- A Missing Page: Base 5%, 100% at 60 Luck
+EID.LuckFormulas["5.350.58"] = function(luck) return (100 / math.max(1, (15 - math.floor(luck*1.5)))) end -- Samson's Lock: Base 6.66%, 100% at 9.34 Luck
+EID.LuckFormulas["5.350.59"] = function(luck) return (100 / math.max(1, (4 - math.floor(luck)))) end -- Cain's Eye: Base 25%, 100% at 3 Luck
+EID.LuckFormulas["5.350.60"] = function(luck) return (100 / math.max(1, (20 - math.floor(luck*2.5)))) end -- Eve's Bird Foot: Base 5%, 100% at 7.6 Luck
+EID.LuckFormulas["5.350.95"] = function(luck) return (100 / math.max(1, (33 - math.floor(luck)))) end -- Black Tooth: Base 3.03%, 100% at 32 Luck
+EID.LuckFormulas["5.350.96"] = function(luck) return (100 / math.max(1, (10 - math.floor(luck)))) end -- Ouroboros Worm: Base 10%, 100% at 9 Luck
 if EID.isRepentance then
+	EID.LuckFormulas["5.100.55"] = function(luck) return (50 + luck*10) end -- Mom's Eye: Base 50%, 100% at 5 Luck
+	EID.LuckFormulas["5.100.87"] = function(luck) return (25 + luck*5) end -- Loki's Horns: Base 25%, 100% at 15 Luck
 	EID.LuckFormulas["5.100.219"] = function(luck) return (20 + luck) end -- Old Bandage: Base 20%, 100% at 80 Luck
+	EID.LuckFormulas["5.100.225"] = function(luck) return (8 + luck*2) end -- Gimpy: Base 8%, 100% at 46 Luck
+	EID.LuckFormulas["5.100.408"] = function(luck) return (25 + luck*2.5) end -- Athame: Base 25%, 100% at 30 Luck
+	EID.LuckFormulas["5.100.495"] = function(luck) return (100 / math.max(2, (12 - math.floor(luck)))) end -- Ghost Pepper: Base 8.33%, 50% at 10 Luck
+	EID.LuckFormulas["5.100.496"] = function(luck) return (100 / math.max(4, (30 - math.floor(luck*2)))) end -- Euthanasia: Base 3.33%, 25% at 13 Luck
+	EID.LuckFormulas["5.100.575"] = function(luck) return (100 / math.max(1, (math.floor(5 - luck)))) end -- The Intruder: Base 20%, 100% at 3.01 Luck
 	EID.LuckFormulas["5.100.576"] = function(luck) return math.min(luck*0.5 + 6.25, 10) end -- Dirty Mind: Base 6.25%, 10% at 7.5 Luck
+	EID.LuckFormulas["5.100.606"] = function(luck) return (100 / math.max(5, (20 - math.floor(luck)))) end -- Ocular Rift: Base 5%, 20% at 15 Luck
+	EID.LuckFormulas["5.100.616"] = function(luck) return (100 / math.max(2, (12 - math.floor(luck)))) end -- Bird's Eye: Base 8.33%, 50% at 10 Luck
+	EID.LuckFormulas["5.100.617"] = function(luck) return (100 / math.max(1, (6 - math.floor(luck)))) end -- Lodestone: Base 16.6%, 100% at 5 Luck
+	EID.LuckFormulas["5.100.618"] = function(luck) return (100 / math.max(1, (6 - math.ceil(luck)))) end -- Rotten Tomato: Base 16.6%, 100% at 4.01 Luck
+	EID.LuckFormulas["5.100.637"] = function(luck) return (100 / math.max(1, (10 - math.floor(luck)))) end -- Knockout Drops: Base 10%, 100% at 9 Luck
+	EID.LuckFormulas["5.350.129"] = function(luck) return (100 / math.max(1, (10 - math.floor(luck)))) end -- Jawbreaker: Base 10%, 100% at 9 Luck
+	EID.LuckFormulas["5.350.130"] = function(luck) return (100 / math.max(1, (10 - math.floor(luck*0.5)))) end -- Chewed Pen: Base 10%, 100% at 18 Luck
+	EID.LuckFormulas["5.350.135"] = function(luck) return math.min(luck*2 + 20) end -- A Lighter: Base 20%, 100% at 40 Luck
+	EID.LuckFormulas["5.350.143"] = function(luck) return math.min(luck*3 + 20, 33) end -- Old Capacitor: Base 20%, 33% at 4.34 Luck
+	EID.LuckFormulas["5.350.188"] = function(luck) return math.min(luck*2 + 20) end -- Ice Cube: Base 20%, 100% at 40 Luck
 end
 
 -- Number of Health Ups you get from a Health Up item

features/eid_holdmapdesc.lua

@@ -411,8 +411,8 @@ EID.ItemReminderDescriptionModifier = {
 
 -- Simple function to help with adding properly formatted sections to the reminder description
 -- returns false, when no further descriptions should be added
-function EID:ItemReminderAddTempDescriptionEntry(icon, title, newDesc)
+function EID:ItemReminderAddTempDescriptionEntry(icon, title, newDesc, objectID)
-	table.insert(EID.ItemReminderTempDescriptions, { icon or "{{Blank}}", title, newDesc })
+	table.insert(EID.ItemReminderTempDescriptions, { icon or "{{Blank}}", title, newDesc, objectID })
 	numAvailableDescriptionSlots = numAvailableDescriptionSlots - 1
 	return EID:ItemReminderCanAddMoreToView()
 end
@@ -482,7 +482,7 @@ function EID:ItemReminderAddDescription(player, entityType, variant, subType, ex
 
 	currentBlacklist[objectID] = true
 	local iconString = extraIcon or EID:GetIconStringByDescriptionObject(descObj)
-	return EID:ItemReminderAddTempDescriptionEntry(iconString, descObj.Name, descObj.Description)
+	return EID:ItemReminderAddTempDescriptionEntry(iconString, descObj.Name, descObj.Description, objectID)
 end
 
 -- In the overview category, check for special descriptions
@@ -499,7 +499,7 @@ function EID:ItemReminderAddSpecialDescriptions(player)
 			if specialDesc.modifierFunction(descObj, player, true) then
 				currentBlacklist[objectID] = true
 				local iconString = EID:GetIconStringByDescriptionObject(descObj)
-				EID:ItemReminderAddTempDescriptionEntry(iconString, descObj.Name, descObj.Description)
+				EID:ItemReminderAddTempDescriptionEntry(iconString, descObj.Name, descObj.Description, objectID)
 			end
 		end
 		if not EID:ItemReminderCanAddMoreToView() then return end
@@ -971,6 +971,10 @@ function EID:ItemReminderGetDescription()
 		if EID.Config["ShowItemName"] then
 			finalHoldMapDesc = finalHoldMapDesc .. "{{ColorEIDObjName}}" .. entry[2]
 		end
+		-- Display Entity ID if its not empty and the config option is enabled
+		if EID.Config["ShowObjectID"] and entry[4] then
+			finalHoldMapDesc = finalHoldMapDesc .. " {{ColorGray}}" .. entry[4]
+		end
 		local description = entry[3] .. "#"
 
 		if tryTrim then

main.lua

@@ -12,8 +12,8 @@ EID.isRepentance = REPENTANCE or EID.isRepentancePlus -- REPENTANCE variable can
 require("eid_config")
 EID.Config = EID.UserConfig
 EID.Config.Version = "3.2" -- note: changing this will reset everyone's settings to default!
-EID.ModVersion = 5.20
+EID.ModVersion = 5.22
-EID.ModVersionCommit = "e18d88d"
+EID.ModVersionCommit = "21fc956"
 EID.DefaultConfig.Version = EID.Config.Version
 EID.isHidden = false
 EID.player = nil -- The primary Player Entity of Player 1

metadata.xml

@@ -56,7 +56,7 @@ There are multiple Versions of the mod, depending on which DLCs you have install
 [img]https://i.imgur.com/jrdGbna.png[/img]
 [url=https://github.com/wofsauge/External-Item-Descriptions/blob/master/CREDITS.md]Check out the credits here[/url]
 </description>
-    <version>5.20</version>
+    <version>5.22</version>
     <visibility>Public</visibility>
     <tag id="Lua"/>
     <tag id="Items"/>