CI: Improved Localization checker to ignore specific false positive errors

.github/scripts/localizationChecker.py

@@ -26,8 +26,9 @@ White='\033[0;37m'        # White
 BWhite='\033[1;37m'       # Bold White
 
 ignoreNodesWithName = {"fonts"}
+ignoreTypeMissmatchNodesWithName = {"ConditionalDescs", "BFFSSynergies"}
 
-maxChecklimit = {"tarotClothBuffs": 2}
+maxChecklimit = {"tarotClothBuffs": 2, "carBattery": 2, "BFFSSynergies": 2}
 
 
 # count en_us entries for stats
@@ -60,15 +61,30 @@ def compare_tables(table1, table2, prev_key):
             # table is missing. add all missing entries as error
             if lupa.lua_type(table1[k]) == "table":
                 errorCount += count_entries(table1[k])
+
         elif lupa.lua_type(table2[k]) != lupa.lua_type(table1[k]):
-            print(f"\tType mismatch in table '{prev_key}', key: {k}")
-            errorCount += 1
+            if lupa.lua_type(table1[k]) == "table" and len(table1[k]) == 1:
+                # ignore missmatch, if comparing table with 1 entry to a single string
+                continue
+            if lupa.lua_type(table2[k]) == "table" and len(table2[k]) == 1:
+                # ignore missmatch, if comparing table with 1 entry to a single string
+                continue
+            # Ignore if node is inside a table to ignore this type of error
+            ignoreError = False
+            for ignoreNode in ignoreTypeMissmatchNodesWithName:
+                if ignoreNode in prev_key:
+                    ignoreError = True
+                    break
+            if not ignoreError:
+                print(f"\tType mismatch in table '{prev_key}', key: {k}")
+                errorCount += 1
+
         elif lupa.lua_type(table2[k]) == "table":
             errorCount += compare_tables(table1[k], table2[k], str(prev_key)+"->"+str(k))
     return errorCount
 
 
-lua.execute('EID = {}; EID.descriptions = {} function EID:updateDescriptionsViaTable(changeTable, tableToUpdate) for k,v in pairs(changeTable) do if v == "" then tableToUpdate[k] = nil else tableToUpdate[k] = v end	end end')
+lua.execute('REPENTOGON = true; EID = {}; EID.descriptions = {} function EID:updateDescriptionsViaTable(changeTable, tableToUpdate) for k,v in pairs(changeTable) do if v == "" then tableToUpdate[k] = nil else tableToUpdate[k] = v end	end end')
 g = lua.globals()
 
 

descriptions/rep/fr.lua

@@ -1441,7 +1441,6 @@ local repConditions = {
 	["Health Up Soul Charges"] = "+{1} charges d'âme",
 	["Health Up Blood Charges"] = "+{1} charges de sang",
 
-	["5.100.705"] = "Dégâts temporaires {{ColorLime}}+1{{CR}} pour chaque ennemi traversé", -- Dark Arts + Dark/Tainted Judas
 	["5.100.722"] = {"Immobilise Ésaü Impur#Réutiliser l'objet ou attendre 5 secondes libère Ésaü, qui fonce vers Jacob"}, -- TJacob + Anima Sola
 	["5.100.713"] = {"Reconvertit les pâtés en PV#Téléporte le surplus de pâtés à Ève#{{Timer}} 1 seconde de recharge"}, --Teve + Sumptorium
 	["5.100.711"] = {"Affiche", "{{Player38}} Passe à l'autre Lazare#Affiche"}, -- Tlaz + Flip